Discussion:
Patch for TortoiseBlame search behavior
Andreas Jönsson
2014-08-22 13:26:01 UTC
Permalink
Hello,

If you use TortoiseBlame on a file and try to search for something which
doesn't exist in the file, you will get a message saying "Search string
not found". Afterwards the main window receives focus and *not* the
search window. In TortoiseDiff the search window receives focus again
and I think this is the better behavior. Please see the attached patch.

Andreas Jönsson

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3087037

To unsubscribe from this discussion, e-mail: [dev-***@tortoisesvn.tigris.org].
Stefan Küng
2014-08-22 15:03:50 UTC
Permalink
Post by Andreas Jönsson
Hello,
If you use TortoiseBlame on a file and try to search for something which
doesn't exist in the file, you will get a message saying "Search string
not found". Afterwards the main window receives focus and *not* the
search window. In TortoiseDiff the search window receives focus again
and I think this is the better behavior. Please see the attached patch.
Thanks for the patch, but this is not the correct way to solve the
problem. Instead, the message box parent window must be the find window,
not the main window.

Committed the correct fix in r25788

Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3087040

To unsubscribe from this discussion, e-mail: [dev-***@tortoisesvn.tigris.org].
Loading...